[openib-general] [PATCH] optional functions, ib_mad update

[Sean Hefty]

On Wed, 01 Sep 2004 16:00:30 -0700
Roland Dreier <roland at topspin.com> wrote:

>     Sean> I thought it might be more complicated as additional checks
>     Sean> were added, but can switch it (and similarly formatted
>     Sean> calls) back to inline for now, then move them later, if
>     Sean> needed.
> 
> I'd rather not go that route -- this is exactly why the kernel
> currently has a bunch of bloated inline functions that should never
> have been inline.  If something isn't in the fast path, let's not
> inline it.

Note that I didn't commit that last patch.  I wanted to get some other responses first.  The only optional calls that I did leave inline in my original tree were the CQ ones that I considered to be speed path operations.  I can easily just ignore my last patch, and I'm open either way here...