[openib-general] RE: [PATCH] osm: add a main auto tools project for osm

[Eitan Zahavi]

Hi Hal,

Thanks applying the patch. 
I will chase down the hard coded -g -O2 .
I'll update my patch mail template...

I was using autoconf 2.57 for a while. It has issues with tracking usage of
the same source code for two executables each with its own set of -D flags.
(like if you want to compile a test program with a "-D_ALOW_MAIN_ ") .
Anyway this is not a must for OpenSM. 

Eitan Zahavi
Design Technology Director
Mellanox Technologies LTD
Tel:+972-4-9097208
Fax:+972-4-9593245
P.O. Box 586 Yokneam 20692 ISRAEL


> -----Original Message-----
> From: Hal Rosenstock [mailto:halr at voltaire.com]
> Sent: Monday, August 15, 2005 6:55 PM
> To: Eitan Zahavi
> Cc: OPENIB GENERAL
> Subject: Re: [PATCH] osm: add a main auto tools project for osm
> 
> Hi Eitan,
> 
> On Mon, 2005-08-15 at 10:23, Eitan Zahavi wrote:
> > I'm now using xemacs as my mail client. This is pure unix and
> > tested to work.
> 
> That's better.
> 
> > This patch includes:
> > 1. Added a top level autotools project for OpenSM.
> >   So now you need autogen.sh && configure && make && make install just
> > once for osm
> >  (previously needed 4: complib, libvendor, opensm, osmtest).
> > 2. Cleanup the direct override of libdir, bindir. Support --prefix
> > 3.  Move osm lib, bin into default prefix (/usr/local)
> > 4. Support debug build for OpenSM using --enable-debug
> >   This is important to allow for asserts during runtime and various
> > other additional debug features.
> >   Since the generated compilb can not be used with the release version
> > we also use a special header file that stores the type of build
> >   for applications that wish to link with it.
> > 5. Cleanup stale use of  AC_CHECK_LIB with no parameters
> > 6. Resolved another bug:  iba/ib_types.h not installed correctly
> 
> Thanks. Applied with the following minor modifications:
> 
> Min autoconf version is 2.57 rather than 2.59
> Min automake version is 1.6.3 rather than 1.9.3
> 
> Also, the builds now show:
> -g -O2 -g -O2 (when not configured with --enable-debug)
> and
> -g -O0 -D_DEBUG_ -g -O2 (when configured with --enable-debug)
> 
> Not sure which -O option gcc takes in that case. Can you remove this
> duplication ?
> 
> > Signed-off-by:  Eitan Zahavi eitan at mellanox.co.il
> 
> The email address should have braces around it in the signed off line:
> Signed-off-by: Eitan Zahavi <eitan at mellanox.co.il>
> 
> -- Hal
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/general/attachments/20050815/e6e216b3/attachment.html>