[openib-general] Re: OpenSM 1.8.0 libvendor initial merge nits

Fab Tillier ftillier at silverstorm.com
Wed Aug 31 11:09:31 PDT 2005


> From: Eitan Zahavi [mailto:eitan at mellanox.co.il]
> Sent: Wednesday, August 31, 2005 10:45 AM
> 
> Hal Rosenstock wrote:
> > Hi again Yael & Eitan,
> >
> > I've now merged the OpenSM 1.8.0 libvendor changes and found
> > the following:
> >
> > General nits:
> >
> > There are a number of violations of the coding style here as well. Also,
> > There is some unneeded whitespace added to a number of files.
>
> We should run osm_check_n_fix this will get this fixed.
> I also think we need to decide if we want to change the OpenSM coding
> style to use tabs or we keep the no-tabs rule.

I personally prefer tabs to spaces, as it has less potential for people's
individual tab width to mess with the code.

- Fab





More information about the general mailing list