[openib-general] Re: OpenSM 1.8.0 libvendor initial merge nits

[Eitan Zahavi]

Fab Tillier wrote:
>>From: Eitan Zahavi [mailto:eitan at mellanox.co.il]
>>Sent: Wednesday, August 31, 2005 10:45 AM
>>
>>Hal Rosenstock wrote:
>>
>>>Hi again Yael & Eitan,
>>>
>>>I've now merged the OpenSM 1.8.0 libvendor changes and found
>>>the following:
>>>
>>>General nits:
>>>
>>>There are a number of violations of the coding style here as well. Also,
>>>There is some unneeded whitespace added to a number of files.
>>
>>We should run osm_check_n_fix this will get this fixed.
>>I also think we need to decide if we want to change the OpenSM coding
>>style to use tabs or we keep the no-tabs rule.
> 
> 
> I personally prefer tabs to spaces, as it has less potential for people's
> individual tab width to mess with the code.
> 
Actually what happens is that if we can not avoid ANY spaces the mix of tabs and spaces
makes the code totally unreadable once you change tab width ...

So unless we avoid any spaces we will have to use all spaces.
That makes the tab width each one uses a don't care.

For coders not using emacs, which supports automatic tab to space replacement (WYSIWYG),
you can still replace all tabs with spaces (as you know your tab width) each time you save.

That is my take.

EZ
> - Fab