[openib-general] [PATCH][IPOIB]mcast restart causes kernel oops

[Shirley Ma]

list_for_each_entry() should be list_for_each_entry_safe() in 
ipoib_mcast_restart_task(). Here is the patch. Please review it.

Signed-off-by: Shirley Ma <xma at us.ibm.com>

diff -urpN infiniband/ulp/ipoib/ipoib_multicast.c 
infiniband-mcast/ulp/ipoib/ipoib_multicast.c
--- infiniband/ulp/ipoib/ipoib_multicast.c      2005-02-24 
20:20:58.000000000 -0800
+++ infiniband-mcast/ulp/ipoib/ipoib_multicast.c        2005-02-28 
09:37:16.387272016 -0800
@@ -908,7 +908,7 @@ void ipoib_mcast_restart_task(void *dev_
        spin_unlock_irqrestore(&priv->lock, flags);
 
        /* We have to cancel outside of the spinlock */
-       list_for_each_entry(mcast, &remove_list, list) {
+       list_for_each_entry_safe(mcast, &remove_list, list) {
                ipoib_mcast_leave(mcast->dev, mcast);
                ipoib_mcast_free(mcast);
        }





Thanks
Shirley Ma
IBM Linux Technology Center
15300 SW Koll Parkway
Beaverton, OR 97006-6063
Phone(Fax): (503) 578-7638

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/general/attachments/20050228/3d1bb1be/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: infiniband-list.patch
Type: application/octet-stream
Size: 598 bytes
Desc: not available
URL: <http://lists.openfabrics.org/pipermail/general/attachments/20050228/3d1bb1be/attachment.obj>