[openib-general] [PATCH][IPOIB]mcast restart causes kernel oops

Roland Dreier roland at topspin.com
Mon Feb 28 10:21:15 PST 2005


Thanks, good catch.

+       list_for_each_entry_safe(mcast, &remove_list, list) {

should really be

+       list_for_each_entry_safe(mcast, tmcast, &remove_list, list) {

though, right?

When you send a patch with a title like "mcast restart causes kernel
oops" can you make it clearer if you actually saw the oops or just
found it by code review?  The best thing to do if you actually see the
oops is to include it with your patch, because then we can make sure
the patch fixes the root cause of the problem.

Also if you are fixing a reproducible oops, please verify that your
patch actually fixes the oops.  Since this patch doesn't even compile,
I know you didn't do that this time ;)

Thanks,
  Roland



More information about the general mailing list