[openib-general] RE: OpenSM: osm_sa_path_record.c minor code redundancy

[Eitan Zahavi]

Correct. The first one should be removed.

Eitan Zahavi
Design Technology Director
Mellanox Technologies LTD
Tel:+972-4-9097208
Fax:+972-4-9593245
P.O. Box 586 Yokneam 20692 ISRAEL


-----Original Message-----
From: Hal Rosenstock [mailto:halr at voltaire.com] 
Sent: Wednesday, January 19, 2005 6:10 PM
To: Eitan Zahavi
Cc: openib-general at openib.org
Subject: OpenSM: osm_sa_path_record.c minor code redundancy

Hi Eitan,

It looks to me like in osm_sa_path_record.c::__osm_pr_rcv_respond that
the second setting of NO RECORDS status is redundant as it is weeded out
earlier in that routine.

  if( num_rec == 0 )
  {
    osm_sa_send_error( p_rcv->p_resp, p_madw,
                       IB_SA_MAD_STATUS_NO_RECORDS );
    goto Exit;
  }
...
  if( num_rec == 0 )
  {
    p_resp_sa_mad->status = IB_SA_MAD_STATUS_NO_RECORDS;
    cl_memclr( p_resp_pr, sizeof(*p_resp_pr) );
  }
  else
  {
...

-- Hal
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/general/attachments/20050119/4b3649be/attachment.html>