[openib-general] [PATCH] sa_query: Add service record support

[Hal Rosenstock]

On Tue, 2005-07-05 at 15:34, Roland Dreier wrote:
>     > +#define IB_DEFAULT_SERVICE_LEASE 	0xFFFFFFFF
> 
> This doesn't seem to be used anywhere?

Right. It is a convenient define for a consumer using Service Records. I
would prefer to leave it in there despite it not being used.

>     > +	/* u16 	resv;	*/
> 
> Can we just delete this comment?

It does map to the actual SR layout and path record indicates where the
reserved fields are.

Is changing it to /* reserved */ acceptable like in the ib_sa_path_rec
struct declaration ?

>     > +	query->sa_query.callback              = ib_sa_service_rec_callback;
> 
> This should probably handle a consumer passing in a NULL callback like
> this other query functions do.

Good catch. I'll update and reissue the patch. Thanks for reviewing it.

BTW, don't forget that the user_mad patch is also pending. Thanks.

-- Hal