[openib-general] [PATCH] sa_query: Add service record support

[Roland Dreier]

    Hal> Right. It is a convenient define for a consumer using Service
    Hal> Records. I would prefer to leave it in there despite it not
    Hal> being used.

OK, that's fine.

    Hal> It does map to the actual SR layout and path record indicates
    Hal> where the reserved fields are.

    Hal> Is changing it to /* reserved */ acceptable like in the
    Hal> ib_sa_path_rec struct declaration ?

Actually, I didn't read the patch carefully enough.  Yes, please
follow the style used in the rest of the file: name the component mask
entries as they are named in the spec, rather than using your own
abbreviations, so you have something like

#define IB_SA_SERVICE_REC_SERVICE_ID			IB_SA_COMP_MASK( 0)
#define IB_SA_SERVICE_REC_SERVICE_GID			IB_SA_COMP_MASK( 1)
#define IB_SA_SERVICE_REC_SERVICE_PKEY			IB_SA_COMP_MASK( 2)
/* reserved:								 3 */
#define IB_SA_SERVICE_REC_SERVICE_LEASE			IB_SA_COMP_MASK( 4)

and so on.  And there's no need to define a component mask for reserved rows.

Then you can put 

	/* reserved */

in the structure definition to match the component mask.

    Hal> BTW, don't forget that the user_mad patch is also
    Hal> pending. Thanks.

Thanks for the reminder.  I'll give it a final review today.

 - R.