[openib-general] RE: [PATCH] ibdm nits and a few questions

[Eitan Zahavi]

Hi Ber,

Thanks for the patch and the word list. I will apply these right away.

> 
> What about removing all the generated scripts (configure et al) and
> auto-tools helpers (aclocal.m4 etc and most of config/*) from the
> repository?
[EZ] I thought I have done that. I will double check.

> Note that the other userspace IB libraries do not have these in the
> repository but each do provide a toplevel ./autogen.sh -- as opposed
> to ibdm's ./config/bootstrap.
[EZ] We can rename the bootstrap autogen.sh but from what I learned about
auto tools many use ./config/bootstrap ...
Is it really annoying?
> 
> 
> There are a number of other unused variables.
[EZ] We should fix all of those! 
> 
> Is ibdm supposed to be compilable with pure ISO c++ compilers, btw?
> There is at least one place which uses a variable sized array which AFAIK
> is not valid ISO c++.
[EZ] I'm not sure what the answer to that is.
> 
> IBMgtSim doesn't compile for me as iba/ib_types.h isn't installed, so
[EZ] You are missing OpenSM installation on the machine. It is required ... 
You can use --with-osm to point to where it is installed ...

> the above is only compile-tested.
[EZ] I will then take the patch manually into the code... (one at a time)


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/general/attachments/20050707/5af2facd/attachment.html>