[openib-general] RE: [PATCH] ibdm nits and a few questions

[Eitan Zahavi]

Hi Ber,

I plan a huge change in the simulator core. So I do not want to waste your
time in cleaning up this code. I have some branch that I use now for
debugging.

I appreciate your check and contribution but as the code I'm about to commit
has many diffs I think it make sense to leave the IBMgtSim for 1 week or so.

I also will ispell the code before committing.

EZ  

Eitan Zahavi
Design Technology Director
Mellanox Technologies LTD
Tel:+972-4-9097208
Fax:+972-4-9593245
P.O. Box 586 Yokneam 20692 ISRAEL


> -----Original Message-----
> From: Bernhard Fischer [mailto:rep.nop at aon.at]
> Sent: Thursday, July 07, 2005 5:00 PM
> To: Eitan Zahavi
> Cc: openib-general at openib.org
> Subject: Re: [PATCH] ibdm nits and a few questions
> 
> On Thu, Jul 07, 2005 at 10:15:15AM +0300, Eitan Zahavi wrote:
> >Hi Ber,
> >
> >Thanks for the patch and the word list. I will apply these right away.
> 
> massage -> message
> randesvous -> rendezvous
> menager -> manager
> contant -> content
> accoumulate -> accumulate
> somthing -> something
> Constractor -> Constructor
> naem -> name
> 
> >
> >>
> >> What about removing all the generated scripts (configure et al) and
> >> auto-tools helpers (aclocal.m4 etc and most of config/*) from the
> >> repository?
> >[EZ] I thought I have done that. I will double check.
> 
> In both ibdm,IBMgtSim there is a configure config/share
> config/libtoolize.
> ibdm/config/depcomp libtool.m4 install-sh are (or should be) all
> generated.
> >
> >> Note that the other userspace IB libraries do not have these in the
> >> repository but each do provide a toplevel ./autogen.sh -- as opposed
> >> to ibdm's ./config/bootstrap.
> >[EZ] We can rename the bootstrap autogen.sh but from what I learned about
> >auto tools many use ./config/bootstrap ...
> >Is it really annoying?
> 
> It's not consistent, but i don't really care either way.
> 
> >> There are a number of other unused variables.
> >[EZ] We should fix all of those!
> 
> IBMgtSim/src/sim.cpp does not compile for me. I tried gcc-3.x as well as
> 4.x to no avail. Ideas?
> sim.cpp:201: error: expected `}' at end of input
> 
> >> Is ibdm supposed to be compilable with pure ISO c++ compilers, btw?
> >> There is at least one place which uses a variable sized array which
AFAIK
> >> is not valid ISO c++.
> >[EZ] I'm not sure what the answer to that is.
> 
> I guess it's a question of policy. If gcc can deal with it, it's fine
> with me, fwiw.
> 
> 
> o IBMSClientInMsgs::proccessClientMsg() strip clientSock which from a
>   short glance seems to be unused.
> 
> Attached patch does:
> in ibmgtsim
> - turn ibms_disconnect() and ibms_disconnect()) into a void functions
> - add static in few places
> - opensm off gen2 doesn't seem to have osm_build_id.h so check for
>   osm_base.h instead
> - correct offset in configure.in's --enable-debug help text
> 
> Signed-off-by: Bernhard Fischer <rep.nop at aon.at>
> 
> Please review the patch and advise on the sim.cpp compile failure i get
> with pristine sources.
> TIA,
> Bernhard

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/general/attachments/20050707/cbb6d961/attachment.html>