[openib-general] [PATCHv3][RFC] kDAPL: use cm timers instead of own

[Talpey, Thomas]

At 04:19 PM 6/1/2005, Tom Duffy wrote:
>> Do any of these tests intentionally trigger timer events? I don't think
>> they do...
>
>Tom, do you know of a test that will?

Can't think of one, actually. Seems like it would take some kind of error
injection. Maybe drop the peer into a debugger while the tests are
running. The main goal being to see that a timer fired, and at about
the right time.
 
>> >static inline u8 dapl_convert_ms_to_kookyib(unsigned long ms) 
>> 
>> Shouldn't this routine live in an IB-specific area, not core DAPL?
>
>Well, maybe, if other ULPs want to use ms instead of IB.  Do you know if
>this is the case?

Hal's right - it does live in an IB-specific file, though that seems to
live in a common directory. I don't think the conversion is sufficiently
general to warrant any special status. Isn't it the case that it is
Mellanox-hardware specific, not even IB-specific?

IOW, I guess it's fine the way it is.

Tom.