[openib-general] Re: [PATCH] kDAPL: remove dat_os_panic()

[James Lentini]

Committed in revision 2683.

On Wed, 22 Jun 2005, Tom Duffy wrote:

tduffy> This patch removes the function dapl_os_panic() in favor of calling
tduffy> panic() directly.
tduffy> 
tduffy> Signed-off-by: Tom Duffy <tduffy at sun.com>
tduffy> 
tduffy> Index: linux-kernel/dat-provider/dapl_evd.c
tduffy> ===================================================================
tduffy> --- linux-kernel/dat-provider/dapl_evd.c	(revision 2677)
tduffy> +++ linux-kernel/dat-provider/dapl_evd.c	(working copy)
tduffy> @@ -681,7 +681,7 @@ static void dapl_evd_cq_async_error_call
tduffy>  		     cause, context);
tduffy>  
tduffy>  	if (!evd)
tduffy> -		dapl_os_panic("NULL == context\n");
tduffy> +		panic("NULL == context\n");
tduffy>  
tduffy>  	async_evd = evd->common.owner_ia->async_error_evd;
tduffy>  
tduffy> @@ -689,9 +689,8 @@ static void dapl_evd_cq_async_error_call
tduffy>  						 DAT_ASYNC_ERROR_EVD_OVERFLOW,
tduffy>  						 async_evd->common.owner_ia);
tduffy>  
tduffy> -	if (status != DAT_SUCCESS) {
tduffy> -		dapl_os_panic("async EVD overflow\n");
tduffy> -	}
tduffy> +	if (status != DAT_SUCCESS)
tduffy> +		panic("async EVD overflow\n");
tduffy>  
tduffy>  	dapl_dbg_log(DAPL_DBG_TYPE_CALLBACK | DAPL_DBG_TYPE_EXCEPTION,
tduffy>  		     "dapl_evd_cq_async_error_callback () returns\n");
tduffy> @@ -707,10 +706,8 @@ void dapl_evd_un_async_error_callback(st
tduffy>  		     "dapl_evd_un_async_error_callback (%p, %p)\n",
tduffy>  		     cause, context);
tduffy>  
tduffy> -	if (NULL == context) {
tduffy> -		dapl_os_panic("NULL == context\n");
tduffy> -		return;
tduffy> -	}
tduffy> +	if (NULL == context)
tduffy> +		panic("NULL == context\n");
tduffy>  
tduffy>  	async_evd = (struct dapl_evd *)context;
tduffy>  
tduffy> Index: linux-kernel/dat-provider/dapl_util.h
tduffy> ===================================================================
tduffy> --- linux-kernel/dat-provider/dapl_util.h	(revision 2677)
tduffy> +++ linux-kernel/dat-provider/dapl_util.h	(working copy)
tduffy> @@ -48,12 +48,6 @@
tduffy>  #include <asm/system.h>
tduffy>  #endif
tduffy>  
tduffy> -#define dapl_os_panic(fmt, args...) 			\
tduffy> -	do {					\
tduffy> -	     printk("PANIC in %s:%i:%s\n", __FILE__, __LINE__, __func__); \
tduffy> -	     panic(fmt, ## args);		\
tduffy> -	} while(0)
tduffy> -
tduffy>  #define dapl_os_assert(expression)                      	\
tduffy>  	do {        						\
tduffy>  		if (!(expression)) {                            \
tduffy>