[openib-general] [PATCH] kDAPL: remove dat_os_panic()

[Grant Grundler]

On Wed, Jun 22, 2005 at 10:17:09AM -0700, Tom Duffy wrote:
> This patch removes the function dapl_os_panic() in favor of calling
> panic() directly.

just some nits...

>  	if (!evd)
> -		dapl_os_panic("NULL == context\n");
> +		panic("NULL == context\n");

Isn't this a bit silly?

>  	async_evd = evd->common.owner_ia->async_error_evd;

The system is going to panic anyway here if evd is null.
I don't see any advantage to testing evd if the only action is to panic.

> -	if (NULL == context) {
> -		dapl_os_panic("NULL == context\n");
> -		return;
> -	}
> +	if (NULL == context)
> +		panic("NULL == context\n");

Would this be better as "BUG_ON(NULL == context)"?

thanks,
grant