[openib-general] Re: [PATCH] IPoIB: Set hardware header on packet receive

[Hal Rosenstock]

On Mon, 2005-03-28 at 11:08, Roland Dreier wrote:
> What is this actually used for?  Wouldn't it make more sense to set
> mac.raw before we pull off the IPoIB header?

I think it depends on how symmetric you want to make the receive side
and what information you want to pass up.

The IPoIB encapsulation actually is needed, otherwise the protocol type
cannot be determined.

The DGID is also probably needed as it addresses the following comment
in ipoib_ib.c:

                                /* XXX get correct PACKET_ type here */
                                skb->pkt_type = PACKET_HOST;

Checking the incoming DGID is the only good way to determine whether the
incoming packet is unicast, broadcast, or multicast.

-- Hal