[openib-general] Re: [PATCH] IPoIB: Set hardware header on packet receive

[Roland Dreier]

    Hal> I think it depends on how symmetric you want to make the
    Hal> receive side and what information you want to pass up.

    Hal> The IPoIB encapsulation actually is needed, otherwise the
    Hal> protocol type cannot be determined.

So we should set mac.raw before the skb_pull rather than where you put
the assignment?

    Hal> The DGID is also probably needed as it addresses the
    Hal> following comment in ipoib_ib.c:

    Hal> /* XXX get correct PACKET_type here */
    skb-> pkt_type = PACKET_HOST;

    Hal> Checking the incoming DGID is the only good way to determine
    Hal> whether the incoming packet is unicast, broadcast, or
    Hal> multicast.

Yes.  I haven't added any code there because just setting PACKET_HOST
all the time doesn't seem to affect anything.

 - R.