Tom Duffy wrote: > - rbuf->base = (void *) kmalloc(rsize * sizeof(void *), GFP_ATOMIC); > + rbuf->base = (void *) kmalloc(rsize * sizeof *rbuf->base, GFP_ATOMIC); Should this be sizeof rbuf->base? Also, do we need any of the casts before the kmallocs? - Sean