[openib-general] [PATCH] kDAPL & at: sizeof is not a function

[Tom Duffy]

On Fri, 2005-05-20 at 10:58 -0700, Sean Hefty wrote:
> Tom Duffy wrote:
> > -	rbuf->base = (void *) kmalloc(rsize * sizeof(void *), GFP_ATOMIC);
> > +	rbuf->base = (void *) kmalloc(rsize * sizeof *rbuf->base, GFP_ATOMIC);
> 
> Should this be sizeof rbuf->base?

rbuf->base is a void **.  I guess it really doesn't matter since they
are the same size.

> Also, do we need any of the casts before the kmallocs?

Nope.  Another patch to get rid of them is forthcoming.

-tduffy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openfabrics.org/pipermail/general/attachments/20050520/d979468f/attachment.sig>