[openib-general] RE: [PATCH] Opensm - handling immediate error in vendor_send new

[Yael Kalka]

Hi Hal,

Hal Rosenstock wrote:

> Hi Yael,
>
> On Tue, 2005-10-11 at 04:28, Yael Kalka wrote:
> > Attached is a new patch with several fixes for this issue.
>
> Thanks. Applied.
>
> There were still extra whitespace issues which I fixed by hand. Please
> try to eliminate these so I don't have to do hand touch ups.
>
I will. Sorry.

> > I decided to remove the checking for zero in the atomic_dec after all,
> > since as I mentioned before - clearing it is not a fix, and we will
> > see the value in other infos in the log file.
>
> But there is danger is these counters wrap, right ?
>
There is still some danger - as you noted - the counters can wrap.
This will happen if there is some problem in the lower layer.
For example - if we get the same mad twice, and we allocated it already
for another request (after getting the first answer).
It shouldn't happen if the lower layer is functioning correctly.

> Also, in looking further at the code, the same issue does not appear to
> occur for QP1 handling, right ?
>
No. There is no such issue in the QP1 handling.

> -- Hal
>


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/general/attachments/20051012/dd3f53a8/attachment.html>