[openib-general] Re: [PATCH] [CM] 2/2 Fix CM redirection in SRP

[Roland Dreier]

    >  	SRP_PORT_REDIRECT	= 1,
    > +	SRP_PORT_REDIRECT	= 2,

You must never have compiled this ;)

    > +struct class_port_info
    > +{
    > +	u8      base_version;
    > +	u8      class_version;
    > +	__be16  capability_mask;
    > +	__be32  resp_time_value;
    > +	u8      redirect_gid[16];
    > +	__be32  redirect_tcslfl;
    > +	__be16  redirect_lid;
    > +	__be16  redirect_p_key;
    > +	__be32  redirect_qp;
    > +	__be32  redirect_q_key;
    > +	u8      trap_gid[16];
    > +	__be32  trap_tcslfl;
    > +	__be16  trap_lid;
    > +	__be16  trap_p_key;
    > +	__be32  trap_hlqp;
    > +	__be32  trap_q_key;
    > +};

I think this belongs in ib_mad.h, not ib_srp.h.

Other than this, I'm OK with this approach if Sean is OK with the CM
changes.  Unfortunately I'm just about to land some changes to the
connection code to handle reconnecting for host resets, so you'll have
to rebase your patches.

Once I get that done (should happen today), please respin your patch,
test with your target and resend.

Thanks,
  Roland