[openib-general] Re: [PATCH] [CM] 2/2 Fix CM redirection in SRP

[John Kingman]

On Fri, 9 Sep 2005, Roland Dreier wrote:

>    >  	SRP_PORT_REDIRECT	= 1,
>    > +	SRP_PORT_REDIRECT	= 2,
>
>You must never have compiled this ;)

Oops, not that patch.  I did compile the right one on the prior 
version, however.  I'll update everything once your latest changes 
are in and test it before creating the next patch.

>    > +struct class_port_info
>    > +{
>    > +	u8      base_version;
>    > +	u8      class_version;
>    > +	__be16  capability_mask;
>    > +	__be32  resp_time_value;
>    > +	u8      redirect_gid[16];
>    > +	__be32  redirect_tcslfl;
>    > +	__be16  redirect_lid;
>    > +	__be16  redirect_p_key;
>    > +	__be32  redirect_qp;
>    > +	__be32  redirect_q_key;
>    > +	u8      trap_gid[16];
>    > +	__be32  trap_tcslfl;
>    > +	__be16  trap_lid;
>    > +	__be16  trap_p_key;
>    > +	__be32  trap_hlqp;
>    > +	__be32  trap_q_key;
>    > +};
>
>I think this belongs in ib_mad.h, not ib_srp.h.

OK, wasn't sure where it should go.  I'll move it.

>Other than this, I'm OK with this approach if Sean is OK with the CM
>changes.  Unfortunately I'm just about to land some changes to the
>connection code to handle reconnecting for host resets, so you'll have
>to rebase your patches.
>
>Once I get that done (should happen today), please respin your patch,
>test with your target and resend.

Will do.

Thanks,

John