[openib-general] Re: [PATCH] uDAPL build fix for OS vendor variations of IA64_FETCHADD

[James Lentini]

On Tue, 27 Sep 2005, Arlin Davis wrote:

> James,
> 
> Please review the following uDAPL patch which fixes some ia64 
> build problems (atomics) with the latest Redhat EL4.0 update and 
> adds support for SuSe. Feel free to come up with a better solution.

Committed in revision 3606 except for this:

> Index: dapl/udapl/Makefile
> ===================================================================
> --- dapl/udapl/Makefile	(revision 3565)
> +++ dapl/udapl/Makefile	(working copy)
> @@ -57,6 +57,13 @@
>  endif
>  
>  #
> +# Set up the default OS Vendor 
> +#
> +ifndef OS_VENDOR
> +OS_VENDOR = REDHAT_EL4
> +endif

I wasn't comfortable changing the compilation behavior to default to 
REDHAT_EL4. I did this instead:

Index: dapl/udapl/Makefile
===================================================================
--- dapl/udapl/Makefile	(revision 3601)
+++ dapl/udapl/Makefile	(working copy)
@@ -57,6 +57,13 @@
 endif
 
 #
+# Set an OS Vendor 
+#
+# OS_VENDOR = REDHAT_EL4
+# OS_VENDOR = SuSE
+#

which I'm not totally happy with, but at least compilation will remain 
the same unless the user makes a change.

Is it time to move to using autogen and configure?