[openib-general] RE: [PATCH] uDAPL build fix for OS vendor variations of IA64_FETCHADD

[Arlin Davis]

>
>Committed in revision 3606 except for this:
>
>> Index: dapl/udapl/Makefile
>> ===================================================================
>> --- dapl/udapl/Makefile	(revision 3565)
>> +++ dapl/udapl/Makefile	(working copy)
>> @@ -57,6 +57,13 @@
>>  endif
>>
>>  #
>> +# Set up the default OS Vendor
>> +#
>> +ifndef OS_VENDOR
>> +OS_VENDOR = REDHAT_EL4
>> +endif
>
>I wasn't comfortable changing the compilation behavior to default to
>REDHAT_EL4. I did this instead:
>
>Index: dapl/udapl/Makefile
>===================================================================
>--- dapl/udapl/Makefile	(revision 3601)
>+++ dapl/udapl/Makefile	(working copy)
>@@ -57,6 +57,13 @@
> endif
>
> #
>+# Set an OS Vendor
>+#
>+# OS_VENDOR = REDHAT_EL4
>+# OS_VENDOR = SuSE
>+#
>
>which I'm not totally happy with, but at least compilation will remain
>the same unless the user makes a change.
>
>Is it time to move to using autogen and configure?

Yes. I am not an autogen/configure expert so I will defer.

In the meantime we need to change things around to build with the latest
changes with no OS_VENDER. This following will build:


Index: dapl/dapl/udapl/Makefile
===================================================================
--- dapl/dapl/udapl/Makefile    (revision 3617)
+++ dapl/dapl/udapl/Makefile    (working copy)
@@ -74,7 +74,11 @@
 #  CFLAGS      Compile time flags for build
 #

-CFLAGS  = -O2 $(CPPFLAGS) -D$(OS_VENDOR) -DOS_VERSION=$(OSRELEASE) -DDAPL_DBG
+CFLAGS  = -O2 $(CPPFLAGS) -DOS_VERSION=$(OSRELEASE) -DDAPL_DBG
+
+ifdef OS_VENDOR
+CFLAGS += -D$(OS_VENDOR)
+endif

 #
 # dummy provider