[openib-general] Re: [PATCH] SRP: don't use TX IU after freeing it

[Roland Dreier]

    Vu> Since all the tuned parameter are target-centralized (passing
    Vu> in when add new target) I think about moving FMR resources
    Vu> (size, max_page...) ie. fmr_pool into srp_target_port
    Vu> struct. Each newly added target will have their own customized
    Vu> FMR pool.

That makes some sense.  An issue is that FMRs are a fairly limited
resource, and a system with many SRP targets where each target doesn't
get much traffic could tie up a lot of FMRs.

    Vu> Have you reviewed the FMR? What your take on Christoph's point
    Vu> about the high bit of dma_address_ts are used by some
    Vu> platforms IOMMU - I think that it's OK since FMR code only
    Vu> touch the lower bit of dma_address_ts

I'm just getting back to looking at SRP.

But I think that it's fine to manipulate dma_addr_t the way that your
code does -- they are bus addresses.

 - R.