[openib-general] Re: [PATCH] SRP: don't use TX IU after freeing it

[Vu Pham]

Roland,


    Vu> Since all the tuned parameter are target-centralized (passing

    Vu> in when add new target) I think about moving FMR resources

    Vu> (size, max_page...) ie. fmr_pool into srp_target_port

    Vu> struct. Each newly added target will have their own customized

    Vu> FMR pool.



That makes some sense.  An issue is that FMRs are a fairly limited

resource, and a system with many SRP targets where each target doesn't

get much traffic could tie up a lot of FMRs.



  

You're right. For the same reason of unused port (ie. srp_host), I
create fmr resource per device and keep it in srp_device_data struct

I put back fmr + your patch and it works well with my setup.

Signed-off-by: Vu Pham  <mailto:sean.hefty at intel.com> <vu at mellanox.com>

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/general/attachments/20050929/3884096b/attachment.html>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: srp.patch
URL: <http://lists.openfabrics.org/pipermail/general/attachments/20050929/3884096b/attachment.ksh>