[openib-general] Re: [PATCH] SRP: don't use TX IU after freeing it

Grant Grundler iod00d at hp.com
Thu Sep 29 23:30:03 PDT 2005


On Thu, Sep 29, 2005 at 09:42:27AM -0700, Roland Dreier wrote:
>     Vu> Have you reviewed the FMR? What your take on Christoph's point
>     Vu> about the high bit of dma_address_ts are used by some
>     Vu> platforms IOMMU - I think that it's OK since FMR code only
>     Vu> touch the lower bit of dma_address_ts
> 
> But I think that it's fine to manipulate dma_addr_t the way that your
> code does -- they are bus addresses.

Sorry - I intended to look more closely at this but have been swamped.

Christoph is right. Even if the code works, it's risky
to muck with the dma_addr_t contents. I'll try to look
at this tomorrow and if I have a better idea, propose it.
(I'm pessimistic that I'll have a better idea though)

grant



More information about the general mailing list