[openib-general] Re: [PATCH] ipoib_mcast_restart_task
Roland Dreier
rdreier at cisco.com
Tue Apr 4 14:04:10 PDT 2006
Michael> ipoib_mcast_restart_task might free an mcast object while
Michael> a join request (sa query) is still outstanding, leading
Michael> to an oops when the query completes. Fix this by waiting
Michael> for query to complete, similiar to what ipoib_stop_thread
Michael> is doing.
Yes, looks like there might be problem here. However, is there any
way to consolidate the "cancel and wait for done" code in one place,
rather than just cut-and-pasting it from ipoib_stop_thread()?
This could explain the oops in ipoib_mcast_sendonly_join_complete(),
but only if a send-only group is being replaced by a full-member
join. Is Eli's test doing that?
- R.
More information about the general
mailing list