[openib-general] Re: [PATCH] ipoib_mcast_restart_task

[Michael S. Tsirkin]

Quoting r. Roland Dreier <rdreier at cisco.com>:
> Subject: Re: [PATCH] ipoib_mcast_restart_task
> 
>     Michael> ipoib_mcast_restart_task might free an mcast object while
>     Michael> a join request (sa query) is still outstanding, leading
>     Michael> to an oops when the query completes.  Fix this by waiting
>     Michael> for query to complete, similiar to what ipoib_stop_thread
>     Michael> is doing.
> 
> Yes, looks like there might be problem here.  However, is there any
> way to consolidate the "cancel and wait for done" code in one place,
> rather than just cut-and-pasting it from ipoib_stop_thread()?

Why not? Please go ahead.

> This could explain the oops in ipoib_mcast_sendonly_join_complete(),
> but only if a send-only group is being replaced by a full-member
> join.  Is Eli's test doing that?

I don't think so.

-- 
Michael S. Tsirkin
Staff Engineer, Mellanox Technologies