[openib-general] [PATCH 5/5 v3] 2.6.20 rdma/cma: export rdma cm interface to userspace

Roland Dreier rdreier at cisco.com
Tue Dec 12 11:30:38 PST 2006


OK, I merged 1..5 up for 2.6.20.  I had to fix a few conflicts with
cma.c cleanups already upstream, and also with the miscdevice
conversion from class device to real device (basically what steve wise
posted a few days ago).

I just pushed the result out in my for-2.6.20 branch if anyone wants
to check, and I'll ask Linus to pull soon.

I did have one question, but we can clean it up later:

 > +		if (signal_pending(current)) {
 > +			ret = -ERESTARTSYS;
 > +			break;
 > +		}
 > +
 > +		prepare_to_wait(&file->poll_wait, &wait, TASK_INTERRUPTIBLE);
 > +		mutex_unlock(&file->mut);
 > +		schedule();
 > +		mutex_lock(&file->mut);
 > +		finish_wait(&file->poll_wait, &wait);

is there any reason why this can't just be written with
wait_event_interruptible() instead of this more-complex way?

 - R.




More information about the general mailing list