[openib-general] [PATCH 5/5 v3] 2.6.20 rdma/cma: export rdma cm interface to userspace
Sean Hefty
mshefty at ichips.intel.com
Tue Dec 12 11:50:36 PST 2006
> > + if (signal_pending(current)) {
> > + ret = -ERESTARTSYS;
> > + break;
> > + }
> > +
> > + prepare_to_wait(&file->poll_wait, &wait, TASK_INTERRUPTIBLE);
> > + mutex_unlock(&file->mut);
> > + schedule();
> > + mutex_lock(&file->mut);
> > + finish_wait(&file->poll_wait, &wait);
>
> is there any reason why this can't just be written with
> wait_event_interruptible() instead of this more-complex way?
I don't think so. The code followed the ucm, which is likely whatever Libor had
done. Did umad or uverbs follow this same format at some point? In any case,
this and the ucm could probably both be cleaned up.
- Sean
More information about the general
mailing list