[openib-general] [PATCH] osm: bug that caused ucast manager to 'hang'

[Hal Rosenstock]

On Fri, 2006-12-15 at 15:03, Eitan Zahavi wrote:
> Hal Rosenstock wrote:
> > On Fri, 2006-12-15 at 12:04, Eitan Zahavi wrote:
> >   
> >> Hal Rosenstock wrote:
> >>     
> >>> Hi again Yevgeny,
> >>>
> >>> On Thu, 2006-12-14 at 14:58, Yevgeny Kliteynik wrote:
> >>>   
> >>>       
> >>>> Hi Hal
> >>>>
> >>>> This patch fixes a bug that caused ucast manager to return
> >>>> OSM_SIGNAL_DONE_PENDING even if there are no pending transactions.
> >>>> Added a boolean flag that marks whether there was some change or not
> >>>> (in which case OSM_SIGNAL_DONE should be returned).
> >>>>
> >>>> --
> >>>> Yevgeny
> >>>>
> >>>> Signed-off-by: Yevgeny Kliteynik <kliteyn at dev.mellanox.co.il>
> >>>>     
> >>>>         
> >>> Good catch!
> >>>
> >>> Thanks. Applied.
> >>>
> >>> Is this issue (and patch or a similar one) also applicable to OFED 1.1 ?
> >>>   
> >>>       
> >> I think OFED 1.1 does not have the "incremental" routing patch.
> >>     
> >
> > Right; it doesn't.
> >
> >   
> >> So it does not have this bug.
> >>     
> >
> > Are you sure that the incremental routing caused this to be needed ? By
> > any chance, are you confusing this with a different patch ? Just want to
> > be clear on this...
> >   
> Yes I am sure. Without the new incremental feature every sweep all LFT 
> tables were set.

That sounds like a different bug to me. Yevgeny's patch was for a hang
which involved issuing OSM_SIGNAL_DONE_PENDING rather than
OSM_SIGNAL_DONE. Is this related to incremental routing ?

-- Hal

> EZ
> > -- Hal
> >
> >   
> >> EZ
> >>     
> >>> -- Hal
> >>>
> >>>
> >>> _______________________________________________
> >>> openib-general mailing list
> >>> openib-general at openib.org
> >>> http://openib.org/mailman/listinfo/openib-general
> >>>
> >>> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
> >>>   
> >>>       
> >
> >
> > _______________________________________________
> > openib-general mailing list
> > openib-general at openib.org
> > http://openib.org/mailman/listinfo/openib-general
> >
> > To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
> >   
>