[openib-general] [PATCH] osm:Fix PathRecord bug in using MTU/rate/PktLife explicitly ignoring selectors

[Eitan Zahavi]

Hal Rosenstock wrote:
> Hi again Eitan,
>
> On Tue, 2006-12-26 at 12:28, Hal Rosenstock wrote:
>   
>> Hi Eitan,
>>
>> On Sun, 2006-12-24 at 07:40, Eitan Zahavi wrote:
>>     
>>> Hi Hal,
>>>
>>> OpenSM just uses the resulting path MTU/rate/pkt-life and fail the
>>> query even though the selector might be allowing for selecting an
>>> appropriate value.
>>>
>>> I have made the attached ibis based program for testing MTU select.
>>>
>>> After this fix the following results are obtained for a case of
>>> path allowing maximal 2K MTU .
>>>
>>> In standard mode:
>>> ------------------------------------------------------------
>>> MTU greater then ... 256     (0x01) ->  equal to ....... 2K
>>> MTU less then ...... 256     (0x41) ->  NO PATHS
>>> MTU equal to ....... 256     (0x81) ->  equal to ....... 256
>>> MTU largest possible 256     (0xc1) ->  equal to ....... 2K
>>> MTU greater then ... 512     (0x02) ->  equal to ....... 2K
>>> MTU less then ...... 512     (0x42) ->  equal to ....... 256
>>> MTU equal to ....... 512     (0x82) ->  equal to ....... 512
>>> MTU largest possible 512     (0xc2) ->  equal to ....... 2K
>>> MTU greater then ... 1K      (0x03) ->  equal to ....... 2K
>>> MTU less then ...... 1K      (0x43) ->  equal to ....... 512
>>> MTU equal to ....... 1K      (0x83) ->  equal to ....... 1K
>>> MTU largest possible 1K      (0xc3) ->  equal to ....... 2K
>>> MTU greater then ... 2K      (0x04) ->  NO PATHS
>>> MTU less then ...... 2K      (0x44) ->  equal to ....... 1K
>>> MTU equal to ....... 2K      (0x84) ->  equal to ....... 2K
>>> MTU largest possible 2K      (0xc4) ->  equal to ....... 2K
>>> MTU greater then ... 4K      (0x05) ->  NO PATHS
>>> MTU less then ...... 4K      (0x45) ->  equal to ....... 2K
>>> MTU equal to ....... 4K      (0x85) ->  NO PATHS
>>> MTU largest possible 4K      (0xc5) ->  equal to ....... 2K
>>> ============================================================
>>>
>>> With enable_quirks (when one of the ends is a Tavor device):
>>> ------------------------------------------------------------
>>> MTU greater then ... 256     (0x01) ->  equal to ....... 1K
>>> MTU less then ...... 256     (0x41) ->  NO PATHS
>>> MTU equal to ....... 256     (0x81) ->  equal to ....... 256
>>> MTU largest possible 256     (0xc1) ->  equal to ....... 2K
>>> MTU greater then ... 512     (0x02) ->  equal to ....... 1K
>>> MTU less then ...... 512     (0x42) ->  equal to ....... 256
>>> MTU equal to ....... 512     (0x82) ->  equal to ....... 512
>>> MTU largest possible 512     (0xc2) ->  equal to ....... 2K
>>> MTU greater then ... 1K      (0x03) ->  NO PATHS
>>> MTU less then ...... 1K      (0x43) ->  equal to ....... 512
>>> MTU equal to ....... 1K      (0x83) ->  equal to ....... 1K
>>> MTU largest possible 1K      (0xc3) ->  equal to ....... 2K
>>> MTU greater then ... 2K      (0x04) ->  NO PATHS
>>> MTU less then ...... 2K      (0x44) ->  equal to ....... 1K
>>> MTU equal to ....... 2K      (0x84) ->  equal to ....... 2K
>>> MTU largest possible 2K      (0xc4) ->  equal to ....... 2K
>>> MTU greater then ... 4K      (0x05) ->  NO PATHS
>>> MTU less then ...... 4K      (0x45) ->  equal to ....... 1K
>>> MTU equal to ....... 4K      (0x85) ->  NO PATHS
>>> MTU largest possible 4K      (0xc5) ->  equal to ....... 2K
>>> ============================================================
>>>
>>> Signed-off-by: Eitan Zahavi <eitan at mellanox.co.il>
>>>       
>> Thanks. Applied. Note osm_sa_multipath_record.c had 2 rejected hunks
>> which were applied by hand.
>>     
>
> Should this be applied for OFED 1.1 as well ?
>   
I would say it should. But I think it deserves OFED group call.
> -- Hal
>
>   
>> -- Hal
>>
>>
>> _______________________________________________
>> openib-general mailing list
>> openib-general at openib.org
>> http://openib.org/mailman/listinfo/openib-general
>>
>> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
>>
>>     
>
>
> _______________________________________________
> openib-general mailing list
> openib-general at openib.org
> http://openib.org/mailman/listinfo/openib-general
>
> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
>