[openib-general] Re: [PATCH] [NET]: Move destructor from neigh->ops to neigh_params

Michael S. Tsirkin mst at mellanox.co.il
Wed Mar 8 16:11:54 PST 2006


Quoting r. Michael S. Tsirkin <mst at mellanox.co.il>:
> Subject: Re: [PATCH] [NET]: Move destructor from neigh->ops to neigh_params
> 
> > The following patch moves this field to neigh_parms where it can be
> > safely set, together with its twin neigh_setup.  Two additional
> > patches in the patch series update ipoib to use this new interface.
> 
> Guys, is there any chance this patch can make it into 2.6.16 still?
> I actually didn't push this since I didn't know about net/atm/clip.c,
> but now I see that without this patch, in 2.6.16 we have two net drivers
> modifying ops->destructor: net/atm/clip.c and drivers/infiniband/ipoib, so they
> conflict.

On a further look, they don't, since clip.c has its own neigh ops
structure which won't ever land on ipoib. So forget it.

-- 
Michael S. Tsirkin
Staff Engineer, Mellanox Technologies



More information about the general mailing list