[openib-general] [PATCH] ib_addr: local/loopback address handling

Sean Hefty mshefty at ichips.intel.com
Mon Mar 27 09:46:58 PST 2006


Michael S. Tsirkin wrote:
> Interpret any ZERONET/LOOPBACK address as INADDR_ANY for address resolution.

> -	if (!src_ip) {
> +	if (ZERONET(src_ip) || LOOPBACK(src_ip)) {
>  		src_in->sin_family = dst_in->sin_family;
>  		src_in->sin_addr.s_addr = dst_ip;
>  		ret = copy_addr(addr, dev, dev->dev_addr);
> 

I'm not as sure about this change; specifically the use of LOOPBACK().  If the 
user specifies 127.0.0.1 for their source address, this will end up changing 
that address to whatever the destination address is.  Is this really what we want?

- Sean



More information about the general mailing list