[openib-general] [PATCH] ib_addr: local/loopback address handling

[Michael S. Tsirkin]

Quoting r. Sean Hefty <mshefty at ichips.intel.com>:
> Subject: Re: [openib-general] [PATCH] ib_addr: local/loopback address handling
> 
> Michael S. Tsirkin wrote:
> >Interpret any ZERONET/LOOPBACK address as INADDR_ANY for address 
> >resolution.
> 
> >-	if (!src_ip) {
> >+	if (ZERONET(src_ip) || LOOPBACK(src_ip)) {
> > 		src_in->sin_family = dst_in->sin_family;
> > 		src_in->sin_addr.s_addr = dst_ip;
> > 		ret = copy_addr(addr, dev, dev->dev_addr);
> >
> 
> I'm not as sure about this change; specifically the use of LOOPBACK().  If 
> the user specifies 127.0.0.1 for their source address, this will end up 
> changing that address to whatever the destination address is.  Is this 
> really what we want?
> 
> - Sean

My testing shows that in sockets 127.0.0.1 is same as 0.


-- 
Michael S. Tsirkin
Staff Engineer, Mellanox Technologies