[openib-general] Problem with using krping

Roland Dreier rdreier at cisco.com
Fri Nov 24 07:37:16 PST 2006


 > I'm a little stumped on the ALIGN macro change. The log entry implies that
 > the change was to fix the ALIGN macro so that it did NOT truncate to int,
 > but it seems to do exactly that. Do you have any insight into this. The file
 > I'm looking at is include/linux/kernel.h.

The change in question is

-#define ALIGN(x,a) (((x)+(a)-1)&~((a)-1))
+#define ALIGN(x,a) (((x)+(a)-1UL)&~((a)-1UL))

right?

So that would force everything to be promoted to a long, even if a is
just an int.

Looks fine to me...




More information about the general mailing list