[openib-general] Problem with using krping

[Tom Tucker]

Yep, but it also demotes a u64 to long, so on 32b architectures it breaks
the amso driver. Pete proposed a trivial fix given the change. The question
is, do we want this for 2.6.19?

Tom

On 11/24/06 9:37 AM, "Roland Dreier" <rdreier at cisco.com> wrote:

>> I'm a little stumped on the ALIGN macro change. The log entry implies that
>> the change was to fix the ALIGN macro so that it did NOT truncate to int,
>> but it seems to do exactly that. Do you have any insight into this. The file
>> I'm looking at is include/linux/kernel.h.
> 
> The change in question is
> 
> -#define ALIGN(x,a) (((x)+(a)-1)&~((a)-1))
> +#define ALIGN(x,a) (((x)+(a)-1UL)&~((a)-1UL))
> 
> right?
> 
> So that would force everything to be promoted to a long, even if a is
> just an int.
> 
> Looks fine to me...