[openib-general] [PATCH 4/13] osm: port to WinIB stack : osmtest/osmtest.c

[Hal Rosenstock]

Hi Eitan,

On Tue, 2006-10-03 at 15:05, Eitan Zahavi wrote:
> Hi Hal,
> 
> I see this was not committed.
> Do you see a reason it should not?

I had gotten part way through the Windows patches before the start of
last week and have not got back to them. This and some others in the
series are still pending.

> Michael had a generic comment of why we do not check range of parsed 
> values which also relates to "safe casting".
> But to completely fix these  we will probably need a  separate patch.

Is this going to be done ? Can it be done the "first" time rather than
committing this and fixing later ?

-- Hal

> Eitan
> 
> Eitan Zahavi wrote:
> 
> >Hi Hal
> >
> >Explicit cast required for the win compiler to handle this...
> >
> >Thanks
> >
> >Eitan
> >
> >Signed-off-by:  Eitan Zahavi <eitan at mellanox.co.il>
> >
> >Index: osmtest/osmtest.c
> >===================================================================
> >--- osmtest/osmtest.c	(revision 9502)
> >+++ osmtest/osmtest.c	(working copy)
> >@@ -3281,7 +3281,7 @@ osmtest_validate_path_data( IN osmtest_t
> >   else
> >   {
> >     /* Also, this doesn't detect fewer than the correct number of paths being returned */
> >-    if ( p_path->count >= ( 1 << lmc ) * ( 1 << lmc ) )
> >+    if ( p_path->count >= (uint32_t)( 1 << (2*lmc)) )
> >     {
> >       osm_log( &p_osmt->log, OSM_LOG_ERROR,
> >                "osmtest_validate_path_data: ERR 0052: "
> >
> >
> >
> >_______________________________________________
> >openib-general mailing list
> >openib-general at openib.org
> >http://openib.org/mailman/listinfo/openib-general
> >
> >To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
> >  
> >
>