[openib-general] [PATCH 4/13] osm: port to WinIB stack : osmtest/osmtest.c

[Hal Rosenstock]

Hi Eitan,

On Tue, 2006-10-03 at 15:05, Eitan Zahavi wrote:
> Hi Hal,
> 
> I see this was not committed.
> Do you see a reason it should not?
> 
> Michael had a generic comment of why we do not check range of parsed 
> values which also relates to "safe casting".
> But to completely fix these  we will probably need a  separate patch.
> 
> Eitan
> 
> Eitan Zahavi wrote:
> 
> >Hi Hal
> >
> >Explicit cast required for the win compiler to handle this...
> >
> >Thanks
> >
> >Eitan
> >
> >Signed-off-by:  Eitan Zahavi <eitan at mellanox.co.il>
> >
> >Index: osmtest/osmtest.c
> >===================================================================
> >--- osmtest/osmtest.c	(revision 9502)
> >+++ osmtest/osmtest.c	(working copy)
> >@@ -3281,7 +3281,7 @@ osmtest_validate_path_data( IN osmtest_t
> >   else
> >   {
> >     /* Also, this doesn't detect fewer than the correct number of paths being returned */
> >-    if ( p_path->count >= ( 1 << lmc ) * ( 1 << lmc ) )
> >+    if ( p_path->count >= (uint32_t)( 1 << (2*lmc)) )

What about Michael's comment:

Does:

	if ( p_path->count >= 1u << (2*lmc))

work for Windows ? If so, that would be better.

-- Hal

> >     {
> >       osm_log( &p_osmt->log, OSM_LOG_ERROR,
> >                "osmtest_validate_path_data: ERR 0052: "
> >
> >
> >
> >_______________________________________________
> >openib-general mailing list
> >openib-general at openib.org
> >http://openib.org/mailman/listinfo/openib-general
> >
> >To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
> >  
> >
>