[ofa-general] Re: skb queue management in ipoib

[Roland Dreier]

 > 	I think that managing this queue in a FIFO manner, dropping
 > 	old packets and inserting new ones instead would be better:
 > 	and older packet has more chance to have been timed out.

Yes, that probably makes sense.

 > 	So we would do something along the lines of:
 > 
 >                        __skb_queue_tail(&neigh->queue, skb);
 >                        if (skb_queue_len(&neigh->queue) > IPOIB_MAX_PATH_REC_QUEUE) {
 >                                 skb = __skb_dequeue_tail(&neigh->queue);

this should just be __skb_dequeue though...

 >                                 ipoib_warn(priv, "queue length limit %d. Packet drop.\n",
 >                                            skb_queue_len(&neigh->queue));
 >                                 goto err_drop;
 >                        }