[ofa-general] Re: skb queue management in ipoib

[Michael S. Tsirkin]

> Quoting Roland Dreier <rdreier at cisco.com>:
> Subject: Re: skb queue management in ipoib
> 
>  > 	I think that managing this queue in a FIFO manner, dropping
>  > 	old packets and inserting new ones instead would be better:
>  > 	and older packet has more chance to have been timed out.
> 
> Yes, that probably makes sense.
> 
>  > 	So we would do something along the lines of:
>  > 
>  >                        __skb_queue_tail(&neigh->queue, skb);
>  >                        if (skb_queue_len(&neigh->queue) > IPOIB_MAX_PATH_REC_QUEUE) {
>  >                                 skb = __skb_dequeue_tail(&neigh->queue);
> 
> this should just be __skb_dequeue though...

Ugh, sure. I'll post something like this for 2.6.23 then?


-- 
MST