[ofa-general] Re: [PATCH] IB/ipoib: optimize receive flow

Roland Dreier rdreier at cisco.com
Wed Oct 10 09:58:39 PDT 2007


 > -	if (!likely(wr_id & IPOIB_CM_RX_UPDATE_MASK)) {
 > +	if (unlikely(wr_id & IPOIB_CM_RX_UPDATE_MASK)) {

This looks dubious -- you've reversed the sense of the test here.

	if (!likely(foo))

should be converted to

	if (unlikely(!foo))

instead.



More information about the general mailing list