[ofa-general] Re: [PATCH] IB/ipoib: optimize receive flow

[Eli Cohen]

On Wed, 2007-10-10 at 09:58 -0700, Roland Dreier wrote:
> > -	if (!likely(wr_id & IPOIB_CM_RX_UPDATE_MASK)) {
>  > +	if (unlikely(wr_id & IPOIB_CM_RX_UPDATE_MASK)) {
> 
> This looks dubious -- you've reversed the sense of the test here.
> 
> 	if (!likely(foo))
> 
> should be converted to
> 
> 	if (unlikely(!foo))
> 
> instead.

Sure, you're right.