[ofa-general] Re: RFC: modify upstream code to make backporting easier

[Roland Dreier]

 > I wonder whether it's acceptable in cases such as this to add
 > a wrapper in upstream code. For example, upstream could have:
 > 
 > #ifndef pci_get_revision
 > #define pci_get_revision(dev) ((dev)->revision)
 > #endif

My feeling is that this type of wrapper is just obfuscation that makes
the driver harder to read and maintain.  If there's a way to make
backporting easier that also makes the upstream driver better, then
I'm in favor of it, but this sounds like a bad example to me.

 - R.