[ofa-general] Re: RFC: modify upstream code to make backporting easier

[Michael S. Tsirkin]

> Quoting Roland Dreier <rdreier at cisco.com>:
> Subject: Re: RFC: modify upstream code to make backporting easier
> 
>  > I wonder whether it's acceptable in cases such as this to add
>  > a wrapper in upstream code. For example, upstream could have:
>  > 
>  > #ifndef pci_get_revision
>  > #define pci_get_revision(dev) ((dev)->revision)
>  > #endif
> 
> My feeling is that this type of wrapper is just obfuscation that makes
> the driver harder to read and maintain.

Note that some people only run
backported drivers, so making it easier to read and maintain
*the backport* is also important.

> If there's a way to make
> backporting easier that also makes the upstream driver better, then
> I'm in favor of it, but this sounds like a bad example to me.

Do you think applying a patch as we do now is the best way to do it then?
Or do you have other ideas on how make backporting this example better?

-- 
MST