[ofa-general] Re: [PATCH] do not change itt endianness

Roland Dreier rdreier at cisco.com
Mon Apr 14 21:09:56 PDT 2008


 > -	itt = ntohl(hdr->itt);
 > +	itt = hdr->itt;

This still gives the sparse warning

    drivers/infiniband/ulp/iser/iser_initiator.c:419:6: warning: incorrect type in assignment (different base types)
    drivers/infiniband/ulp/iser/iser_initiator.c:419:6: expected unsigned int [unsigned] itt
    drivers/infiniband/ulp/iser/iser_initiator.c:419:6: got restricted unsigned int [usertype] itt

I guess the two possibilities are to use get_itt() or use a __force cast
if you don't want the masking that get_itt() does.  Which is correct?

 - R.



More information about the general mailing list