[ofa-general] Re: [PATCH] do not change itt endianness

Erez Zilber erezz at Voltaire.COM
Mon Apr 14 23:33:29 PDT 2008


Roland Dreier wrote:
>  > -	itt = ntohl(hdr->itt);
>  > +	itt = hdr->itt;
>
> This still gives the sparse warning
>
>     drivers/infiniband/ulp/iser/iser_initiator.c:419:6: warning: incorrect type in assignment (different base types)
>     drivers/infiniband/ulp/iser/iser_initiator.c:419:6: expected unsigned int [unsigned] itt
>     drivers/infiniband/ulp/iser/iser_initiator.c:419:6: got restricted unsigned int [usertype] itt
>
> I guess the two possibilities are to use get_itt() or use a __force cast
> if you don't want the masking that get_itt() does.  Which is correct?
>
>  - R.
>   

Roland,

If I just run 'make', I don't see the warning. What should I do in order
to get the same warning that you get?

Thanks,
Erez



More information about the general mailing list