[ofa-general] [PATCH] IB/libipathverbs - Update %install section of libipathverbs.spec
Ralph Campbell
ralph.campbell at qlogic.com
Fri Feb 1 16:25:17 PST 2008
Change from using the %makeinstall macro to using "make install"
directly. The page <http://fedoraproject.org/wiki/Packaging/Guidelines>
has this to say:
"Fedora's RPM includes a %makeinstall macro but it must NOT be used
when make install DESTDIR=%{buildroot} works. %makeinstall is a kludge....
It is error-prone and can have unexpected effects....
It can trigger unnecessary and wrong rebuilds....
....it can cause broken *.la files to be installed....
Instead, Fedora packages should use: make DESTDIR=%{buildroot}
install or make DESTDIR=$RPM_BUILD_ROOT install"
Signed-off-by: Ralph Campbell <ralph.campbell at qlogic.com>
diff --git a/libipathverbs.spec.in b/libipathverbs.spec.in
index 9bc11eb..1283dd1 100644
--- a/libipathverbs.spec.in
+++ b/libipathverbs.spec.in
@@ -72,7 +72,7 @@ make %{?_smp_flags}
%install
rm -rf $RPM_BUILD_ROOT
-%makeinstall
+make DESTDIR=$RPM_BUILD_ROOT install
# remove unpackaged files from the buildroot
rm -f $RPM_BUILD_ROOT%{_libdir}/*.la
More information about the general
mailing list