[ofa-general] Re: [PATCH 4/16 v4] IB/ipoib: Add checksum offload support

[Eli Cohen]

On 2/9/08, Roland Dreier <rdreier at cisco.com> wrote:
> I'm a little worried here:
>
>  > +            if (priv->ca->flags & IB_DEVICE_IP_CSUM)
>  > +                    dev->features |= NETIF_F_IP_CSUM | NETIF_F_SG;
>
> I don't see any place that ca->flags ever gets set; in fact if I
> delete the flags member of struct ib_device from my tree, it all still
> compiles fine.

I set these flags for mlx4 and mthca in patches 5/16 and 6/16 respectively.

>
> So have you actually tested any of these checksum offload code paths?
>

I my machines I can see the flags set by inspecting /sys/class/net/ib*/features