[ofa-general] Re: [PATCH 4/16 v4] IB/ipoib: Add checksum offload support

Roland Dreier rdreier at cisco.com
Mon Feb 11 14:28:42 PST 2008


 > I set these flags for mlx4 and mthca in patches 5/16 and 6/16 respectively.

Ah I see.  Seems strange to use device->flags for just the checksum
offload stuff and device_cap_flags for everything else though.  I
don't see any major issues with moving device_cap_flags into struct
ib_device and not forcing a device query call, but I guess we need to
convince ourselves that the flags would never change at runtime, and
anyway that needs to be a separate change from this IPoIB stuff.

 > I my machines I can see the flags set by inspecting /sys/class/net/ib*/features

I guess that's an OFED patch?  Is there any interest in submitting it
upstream.

 - R.



More information about the general mailing list